11893

pending completion

Build # 11893

Build Type

push

travis-ci

Committed by

TheAviat0r

Commit Message

sql: remove unnecessary MakeRecord opcodes

OP_MakeRecord in INSERT/UPDATE query is required for making
insertion into Tarantool and for checking constraints with
ON CONFLICT clause. There was one OP_MakeRecord for each
constraint with ON CONFLICT, and each constraint was checked by
VDBE. But now some constraints with error actions like ABORT can
be handled by Tarantool facilities (without emitting bytecode) and
therefore MakeRecord for that index would be unnecessary if it is
not a primary key index (in that case MakeRecord is also needed
for OP_IdxInsert). This patch contains a fix, which removes
unnecessary MakeRecord opcodes from INSERT/UPDATE VDBE listings.

Closes #3317

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

60373 of 75230 relevant lines covered (80.25%)

1500290.91 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.4

/src/lib/small/test/rb_rand.cc

Source Not Available

The file "src/lib/small/test/rb_rand.cc" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.

tarantool / tarantool / 11893

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available

Source File
Press 'n' to go to next uncovered line, 'b' for previous