Ran
|
Jobs
2
|
Files
99
|
Run time
13min
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
<a href="https://github.com/Instagram/IGListKit/commit/e49c94b25">Show header when section item is empty Summary: Issue fixed: #1117 I adding a new constructor for making a `IGListCollectionViewLayout` instance that can always show sticky header although section data is empty. It's working well and [this is demo project](https://github.com/marcuswu0814/IGListKit_ShowStickyHeaderWhenDataEmpty). Bug I'm not sure is any good way to let this much more readability. Is there any good advice? ```objc const CGRect headerBounds = (self.scrollDirection == UICollectionViewScrollDirectionVertical) ? CGRectMake(insets.left, (itemCount == 0) ? CGRectGetMaxY(rollingSectionBounds) : CGRectGetMinY(rollingSectionBounds) - headerSize.height, paddedLengthInFixedDirection, headerSize.height) : CGRectMake((itemCount == 0) ? CGRectGetMaxX(rollingSectionBounds) : CGRectGetMinX(rollingSectionBounds) - headerSize.width, insets.top, headerSize.width, paddedLengthInFixedDirection); ``` - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1129 Differential Revision: D7551628 Pulled By: rnystrom fbshipit-source-id: </a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/a60b65a92">a60b65a92</a>
12605 of 13234 relevant lines covered (95.25%)
514.32 hits per line
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|