pantsbuild / pants / 2883
66%
main: 80%

LAST BUILD BRANCH: gha-deps
DEFAULT BRANCH: main
Ran
Jobs 5
Files 315
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2883

push

travis-ci

jsirois 
Fix the ScroogeGen target selection predicate.

This also updates the release version and CHANGELOG
in anticipation of a quick release.

Testing Done:
Before this fix, reproed the current CI failures with:
```console
$ pants.dev clean-all test examples/::
...
19:52:10 00:20         [compile]
19:52:10 00:20           [jmake]
                         warning: bootstrap class path not set in conjunction with -source 1.6
                         Jmake version 1.3.8-3
                         /home/jsirois/dev/3rdparty/pants/.pants.d/gen/scrooge/java-sync/com/pants/examples/distance/thriftjava/Distance.java:32: error: duplicate class: com.pants.examples.distance.thriftjava.Distance
                         public class Distance implements TBase<Distance, Distance._Fields>, java.io.Serializable, Cloneable {
                                ^
                         /home/jsirois/dev/3rdparty/pants/.pants.d/gen/scrooge/java-sync/com/pants/examples/precipitation/thriftjava/Precipitation.java:32: error: duplicate class: com.pants.examples.precipitation.thriftjava.Precipitation
                         public class Precipitation implements TBase<Precipitation, Precipitation._Fields>, java.io.Serializable, Cloneable {
                                ^
                         Writing project database...  Done.

FAILURE: compilation error
...
$ find .pants.d -type f | xargs grep "package com.pants.examples.distance.thriftjava"
.pants.d/gen/thrift/sessions/examples.src.thrift.com.pants.examples.precipitation.precipitation.thrift/gen-java/com/pants/examples/distance/thriftjava/Distance.java:package com.pants.examples.distance.thriftjava;
.pants.d/gen/thrift/combined/gen-java/com/pants/examples/distance/thriftjava/Distance.java:package com.pants.examples.distance.thriftjava;
.pants.d/gen/scrooge/java-sync/com/pants/examples/distance/thriftjava/Distance.java:package com.pants.examples.distance.thriftjava;
...
```

After the fix the examples run green and:
```console
... (continued)

4 of 4 new or added lines in 2 files covered. (100.0%)

12022 of 18131 relevant lines covered (66.31%)

0.66 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
100.0
 src/python/pants/backend/codegen/tasks/scrooge_gen.py
Jobs
ID Job ID Ran Files Coverage
1 2883.1 (CI_FLAGS="-c") 0
66.31
 Travis Job 2883.1
2 2883.2 (CI_FLAGS="-srpeat -i 4:0") 0
Travis Job 2883.2
3 2883.3 (CI_FLAGS="-srpeat -i 4:1") 0
Travis Job 2883.3
4 2883.4 (CI_FLAGS="-srpeat -i 4:2") 0
Travis Job 2883.4
5 2883.5 (CI_FLAGS="-srpeat -i 4:3") 0
Travis Job 2883.5
Source Files on build 2883
Detailed source file information is not available for this build.