24
72%

Ran 17 Mar 2018 01:57PM UTC

Jobs 1

Files 396

Run time 20s

Badge

Embed ▾

pending completion

Build # 24

Build Type

push

jenkins

Committed by Sijie Guo

Commit Message

Improve `BookKeeperAdmin#format` to avoid constructing redundant resources

Descriptions of the changes in this PR:

*Problem*

After metadata service uri change, all the metadata managers can be retrieved via metadata drivers.
So there is no need to construct another bookkeeper client to get ledger manager factory for formatting ledger metadata.

*Solution*

- remove constructing bookkeeper client and use the metadata driver to get ledger manager factory to format ledger metadata
- expose layout manager in bookie driver as well
- since we are adding `getLayoutManager` in bookie driver, we need to update `MetadataDriversTest`. cleanup the test drivers in `MetadataDriversTest`.

Related Issue: #1269

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>

This closes #1270 from sijie/improve_format

Run Details

22993 of 31700 relevant lines covered (72.53%)

0.73 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	24.1	17 Mar 2018 01:57PM UTC	396	72.53

apache / bookkeeper / 24
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 24

apache / bookkeeper / 24 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 24

apache / bookkeeper / 24
72%

README BADGES
x