23
72%

Ran 16 Mar 2018 02:08PM UTC

Jobs 1

Files 396

Run time 26s

Badge

Embed ▾

pending completion

Build # 23

Build Type

push

jenkins

Committed by Sijie Guo

Commit Message

BP-29 (task 4): use metadata service uri for constructing registration manager and ledger manager factory

Descriptions of the changes in this PR:

The main changes are at two places:

- Deprecating using ServerConfiguration#getRegistrationManagerClass(). Changed Bookie.java to use MetadataBookieDriver to getRegistrationManager().
- Use MetadataBookieDriver/MetadataClientDriver to retrieve ledger manager factory in Bookie.java / BookKeeper.java

The other changes are in-place changes for replacing using registration manager to using metadata drivers.

- provides a few util functions in `MetadataDrivers` to run `functions` with registration manager / ledger manager factory

Master Issue: #1123

Author: Sijie Guo <sijie@apache.org>

Reviewers: Jia Zhai <None>

This closes #1251 from sijie/use_metadata_service_uri_in_registration_manager

Run Details

388 of 388 new or added lines in 16 files covered. (100.0%)

22931 of 31664 relevant lines covered (72.42%)

0.72 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	79.63	0.5%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
3	72.92	0.09%	bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationManager.java
3	72.46	-2.73%	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManagerFactory.java
3	91.3	-1.38%	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MetadataDrivers.java
4	83.87	5.22%	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java
4	0.0	0.0%	bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/ExpandStorageService.java
4	73.91	-0.56%	bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/RecoveryBookieService.java
14	67.18	4.96%	bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
19	72.81	-2.69%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java
110	31.84	-0.54%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java

Uncovered Existing Lines

Lines	Coverage	∆	File
1	91.16	-0.47%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
1	78.9	0.0%	bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
1	83.87	5.22%	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java
1	95.83	-4.17%	bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBaseV3.java
1	73.64	-0.78%	bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessorV3.java
1	79.85	-0.45%	bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
1	86.11	-2.78%	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java
2	72.75	0.0%	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java
2	90.43	-2.13%	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LegacyHierarchicalLedgerManager.java
2	84.43	0.17%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
2	83.7	-0.37%	bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
2	80.0	-4.0%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java
2	54.55	-6.06%	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLayoutManager.java
3	36.84	-3.16%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieException.java
3	72.46	-2.73%	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManagerFactory.java
3	88.35	-2.91%	bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
4	74.19	0.0%	bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
4	87.95	-0.8%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
5	91.06	-2.03%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.java
10	31.84	-0.54%	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	23.1	16 Mar 2018 02:08PM UTC	396	72.42

apache / bookkeeper / 23
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 23

apache / bookkeeper / 23 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 23

apache / bookkeeper / 23
72%

README BADGES
x