grpc / grpc-java / 9464

89%

push

travis-ci

<a href="https://github.com/grpc/grpc-java/commit/<a class=hub.com/grpc/grpc-java/commit/<a class="double-link" href="https://git"><a class=hub.com/grpc/grpc-java/commit/26719bdc5cce359da7ac8317d639847015825e6f">26719bdc5<a href="https://github.com/grpc/grpc-java/commit/26719bdc5cce359da7ac8317d639847015825e6f">&lt;a href=&quot;https://github.com/grpc/grpc-java/commit/26719bdc5cce359da7ac8317d639847015825e6f&quot;&gt;&amp;quot;&amp;gt;Partially revert &amp;quot;core: change serverimpl,servercallimpl&amp;#39;s internalclose to cancel stream (#4038)&amp;quot;

This partially reverts commit &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/grpc/grpc-java/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/grpc/grpc-java/commit/48ca4527c14a95914f9cb7f58ec72997cb96899a&quot;&gt;48ca4527c&lt;/a&gt;&quot;&gt;48ca4527c&lt;/a&gt;&lt;a href="https://github.com/grpc/grpc-java/commit/26719bdc5cce359da7ac8317d639847015825e6f">.
It leaves the changes to ServerCallImpl and test.

This also partially reverts &quot;Lint fixes&quot; commit
</a><a class="double-link" href="https://github.com/grpc/grpc-java/commit/<a class="double-link" href="https://github.com/grpc/grpc-java/commit/3002a23a0ff9f72cc29c81b3be456d2ee1fa6bc4">3002a23a0</a>">3002a23a0</a><a href="https://github.com/grpc/grpc-java/commit/26719bdc5cce359da7ac8317d639847015825e6f"> which removed unused variables
which are now necessary again.

This is reverted for the combined result of two issues:
* Some users are testing that they get UNKNOWN when the service throws.
  That&#39;s not unreasonable given the behavior was well-publicised when it
  changed in v1.5. We should probably keep the UNKNOWN in some common
  cases (like the service threw immediately, before sending anything).
* The client could see CANCELLED instead of INTERNAL as had been
  intended. It's unclear as to why (I didn't investigate heavily). This
  behavior is visible in MoreInProcessTest and was overlooked during
  review.

2 of 2 new or added lines in 2 files covered. (100.0%)

13180 of 14886 relevant lines covered (88.54%)

0.89 hits per line