apache / bookkeeper / 8
72%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 393
Run time 32s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8

push

jenkins

sijie 
Support LacPiggyback, LongPoll and ExplicitLac in db ledger storage

Descriptions of the changes in this PR:

*Motivation*

DbLedgerStorage was developed in yahoo and just merged recently to master. This implementation only works for v2 protocol.
It doesn't work with v3 protocol. When using v3 protocol clients (e.g. dlog library) to talk to bookies use DbLedgerStorage,
the clients hang on waiting responses. because a few methods in DbLedgerStorage throw UnsupportedException

*Solution*

This change focuses on adding the implementations for those methods, in order to support LacPiggyback, LongPoll and ExplicitLac
for v3 protocol. The implementation follows what we had in FileInfoCache but did it in a much simpler way, since all the persistence
information has been managed by db ledger storage itself. All the information required by `LacPiggyback`, `LongPoll` and `ExplicitLac`
are transient.

This change doesn't introduce any new test cases. It reuses existing test cases to test those features using DbLedgerStorage. These
tests are:

- ExplicitLacTest: for testing explicit lac
- TestPiggybackLAC: for testing piggback lac
- TestReadLastConfirmedLongPoll: for testing long polling lac
- TestReadLastConfirmedAndEntry: for testing entry piggyback

Author: Sijie Guo <sijie@apache.org>

Reviewers: Ivan Kelly <ivank@apache.org>, Matteo Merli <mmerli@apache.org>

This closes #1218 from sijie/support_long_polls

22836 of 31400 relevant lines covered (72.73%)

0.73 hits per line

Jobs
ID Job ID Ran Files Coverage
1 8.1 0
72.73
Source Files on build 8