jaegertracing / jaeger-client-node / 1192

97%

push

travis-ci

Change UDPSender callbacks to (numSpans: number, err?: string) => void (#226)

- Add proper type signatures to UDPSender and Reporter callbacks (instead of ?Function)
- Define sender callbacks as `(numSpans: number, err?: string) => void` instead of passing a SenderResponse object (avoids unnecessary memory allocation)
- Remove logging from UDPSender, instead return the error to the reporter that logs it
- Fix the tests (`done()` was called in the middle of some tests, aborting them prematurely)

Signed-off-by: Yuri Shkuro <ys@uber.com>

518 of 562 branches covered (92.17%)

Branch coverage included in aggregate %.

43 of 43 new or added lines in 3 files covered. (100.0%)

1139 of 1150 relevant lines covered (99.04%)

47.48 hits per line