2054
100%

Ran 05 Feb 2018 08:49PM UTC

Jobs 2

Files 95

Run time 246min

Badge

Embed ▾

pending completion

Build # 2054

Build Type

push

travis-ci

Committed by

facebook-github-bot

Commit Message

<a href="https://github.com/Instagram/IGListKit/commit/c617b18eb">Move the DEBUG uniqueness check outside of for-loop inside IGListAdapter

Summary:
The original DEBUG was put inside a for loop, which caused a quadratic looping while creating bigger and bigger NSSet.

This is very inefficient and I verified that by profiling with 10000 objects in the array and it caused significant amount of CPU. The main thread is pretty much unresponsive.
Closes https://github.com/Instagram/IGListKit/pull/1084

Reviewed By: rnystrom

Differential Revision: D6903043

Pulled By: lorixx

fbshipit-source-id: </a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/311e8a402">311e8a402</a>

Run Details

11990 of 12330 relevant lines covered (97.24%)

564.27 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	2054.2 (DESTINATION="OS=10.3.1,name=iPhone 7" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" RUN_UI_TESTS="NO" BUILD_EXAMPLE="YES" POD_LINT="NO", Gemfile)	05 Feb 2018 08:49PM UTC	0	97.24	Travis Job 2054.2
3	2054.3 (DESTINATION="OS=11.2,name=iPhone X" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" RUN_UI_TESTS="YES" BUILD_EXAMPLE="YES" POD_LINT="NO", Gemfile)	05 Feb 2018 08:58PM UTC	0	97.22	Travis Job 2054.3

Source Files on build 2054

Detailed source file information is not available for this build.

Instagram / IGListKit / 2054
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2054

Instagram / IGListKit / 2054 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2054

Instagram / IGListKit / 2054
100%

README BADGES
x