zalando-incubator / kube-ingress-aws-controller / 361

72%

push

travis-ci

Predictably select subnets (#117)

* Predictably select subnets

This changes the logic of selecting subnets for the ALB to match the logic used
by the kube-controller-manager when selecting subnets for ELBs used for
services of type LoadBalancer.

This solves several problems:

1. The controller will no longer try to create an ALB with multiple subnets of
the same AZ. (Fixes #108)

2. If only some subnets are tagged with the elb role the controller will favour
those with the tag but not limit the selection to only those with a tag.

3. Favour using internal subnets for ALBs with the scheme `internal`.

Fix #108

* Predictably select subnets

This changes the logic of selecting subnets for the ALB to match the logic used
by the kube-controller-manager when selecting subnets for ELBs used for
services of type LoadBalancer.

This solves several problems:

1. The controller will no longer try to create an ALB with multiple subnets of
the same AZ. (Fixes #108)

2. If only some subnets are tagged with the elb role the controller will favour
those with the tag but not limit the selection to only those with a tag.

3. Favour using internal subnets for ALBs with the scheme `internal`.

Fix #108

44 of 44 new or added lines in 3 files covered. (100.0%)

861 of 1549 relevant lines covered (55.58%)

5.66 hits per line