pantsbuild / pants / 2601
0%

DEFAULT BRANCH: master
Ran
Jobs 5
Files 318
Run time 42min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2601

push

travis-ci

Tejal Desai 
Add java_sources to the depmap-info.

More context:
Ity added this diff long long ago https://rbcommons.com/s/twitter/r/733 to include java_sources in self.context which had some performance issues.

I went ahead and removed it https://rbcommons.com/s/twitter/r/1130.
We relied on java_sources to be already present in self.targets for depmap goal.

This diff fixes the issue where for a scala target owning java_sources, the java_target is included in depmap output under targets found.

Without this patch, the java_sources is mising from targets but is present in targets['examples/src/scala/com/pants/example/scala_with_java_sources:scala_with_java_source']['targets']

[tw-172-25-146-131 pants]$ ./pants goal depmap --depmap-project-info examples/src/scala/com/pants/example/scala_with_java_sources:
*** Running pants in dev mode from /Users/tdesai/projects/pants/src/python/pants/bin/pants_exe.py ***
{
    "libraries": {},
    "targets": {
        "examples/src/scala/com/pants/example/scala_with_java_sources:scala_with_java_sources": {
            "libraries": [
                "org.scala-lang:scala-library:2.9.3"
            ],
            "is_code_gen": false,
            "targets": [
                ":scala-library-2.9.3",
                "examples/src/java/com/pants/examples/java_sources:java_sources"
            ],
            "roots": [
                {
                    "source_root":   "/Users/tdesai/projects/pants/examples/src/scala/com/pants/example/scala_with_java_sources",
                    "package_prefix": "com.pants.example.scala_with_java_sources"
                }
            ],
            "target_type": "SOURCE"
        },

        "examples/src/java/com/pants/examples/java_sources:java_sources": {
            "libraries": [],
            "is_code_gen": false,
            "targets": [],
            "roots": [
                {
                    "source_root": "/Users/tdesai/projects/pants/examples/src/java/com/pants/examples/java_sources",
                    "package_prefix": "com.pants.examples.java_sources"
                }
            ],
            "target_type": "SOURCE"
        },
        ":scala-library-2.9.3": {
            "libraries": [],
            "is_code_gen": false,
            "targets": [],
            "roots": [],
            "target_type": "SOURCE"
        }
    }
}

Testing Done:
yes.

./pants tests/python/pants_test/tasks:depmap_integration

and
./pants tests/python/pants_test/tasks:depmap

pass

CI:
https://travis-ci.org/pantsbuild/pants/builds/40829185

Reviewed at https://rbcommons.com/s/twitter/r/1324/

11874 of 18260 relevant lines covered (65.03%)

0.65 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2601.1 (CI_FLAGS="-c") 318
65.03
 Travis Job 2601.1
2 2601.2 (CI_FLAGS="-srpeat -i 4:0") 0
Travis Job 2601.2
3 2601.3 (CI_FLAGS="-srpeat -i 4:1") 0
Travis Job 2601.3
4 2601.4 (CI_FLAGS="-srpeat -i 4:2") 0
Travis Job 2601.4
5 2601.5 (CI_FLAGS="-srpeat -i 4:3") 0
Travis Job 2601.5
Source Files on build 2601
Coverage ∆ File Lines Relevant Covered Missed Hits/Line