595
97%

Ran 10 Nov 2014 10:25AM UTC

Jobs 2

Files 43

Run time 1min

Badge

Embed ▾

pending completion

Build # 595

Build Type

Pull #493

travis-ci

Committed by

stianpr

Commit Message

Add Python 3 support for FacebookAuthorization.parse_signed_data

`json.loads` was expecting a string, but in python 3 `base64decode()`
return bytes and that is why it bugged. We fix this by making sure
the decoded payload data is in string and that `hmac.new()` is
provided with arguments in bytes. `open_facebook.utils.smart_str`
will do that job correctly in python 2 and 3.

We also use `hmac.compare_digest()` which is the preferred way to
compare those kinds of data to prevent timing analysis. If not
`hmac.compare_digest` is available (python 2.7.7+) then we just compare
logically.

Fixes #491.

Pull Request Pull Request #493: Add Python 3 support for FacebookAuthorization.parse_signed_data

Run Details

2184 of 3472 relevant lines covered (62.9%)

1.26 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
70	100.0		home/travis/build/tschellenbach/Django-facebook/open_facebook/api.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	595.1 (DJANGO=1.6.8 CUSTOM_USER_MODEL=0 MODE=standalone REQUIREMENTS=development6 SETTINGS=facebook_example.settings TESTS=django_facebook open_facebook)	10 Nov 2014 10:25AM UTC	0	62.9	Travis Job 595.1
2	595.2 (DJANGO=1.6.8 CUSTOM_USER_MODEL=1 MODE=standalone REQUIREMENTS=development6 SETTINGS=facebook_example.settings TESTS=django_facebook open_facebook)	10 Nov 2014 10:25AM UTC	0	62.9	Travis Job 595.2

Source Files on build 595

Detailed source file information is not available for this build.

tschellenbach / Django-facebook / 595
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 595

tschellenbach / Django-facebook / 595 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 595

tschellenbach / Django-facebook / 595
97%

README BADGES
x