tschellenbach / Django-facebook / 595

pending completion

Build # 595

Build Type

Pull #493

travis-ci

Committed by

stianpr

Commit Message

Add Python 3 support for FacebookAuthorization.parse_signed_data

`json.loads` was expecting a string, but in python 3 `base64decode()`
return bytes and that is why it bugged. We fix this by making sure
the decoded payload data is in string and that `hmac.new()` is
provided with arguments in bytes. `open_facebook.utils.smart_str`
will do that job correctly in python 2 and 3.

We also use `hmac.compare_digest()` which is the preferred way to
compare those kinds of data to prevent timing analysis. If not
`hmac.compare_digest` is available (python 2.7.7+) then we just compare
logically.

Fixes #491.

Pull Request Pull Request #493: Add Python 3 support for FacebookAuthorization.parse_signed_data

Run Details

2184 of 3472 relevant lines covered (62.9%)

1.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

32.97

/home/travis/build/tschellenbach/Django-facebook/open_facebook/api.py

Source Not Available

The file "home/travis/build/tschellenbach/Django-facebook/open_facebook/api.py" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.

tschellenbach / Django-facebook / 595

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available

Source File
Press 'n' to go to next uncovered line, 'b' for previous