2422
0%
main: 93%

Ran 30 Oct 2014 07:56PM UTC

Jobs 2

Files 319

Run time 6min

Badge

Embed ▾

pending completion

Build # 2422

Build Type

push

travis-ci

Committed by Ity Kaul

Commit Message

Fix the regression introduced in https://rbcommons.com/s/twitter/r/1186/

The original code in benchmark_run.py was:

  option_group.add_option(mkflag("target"), dest="target_class", action="append",
                            help="Name of the benchmark class.")
  ...
  ...
  self.caliper_args = self.context.options.target_class
  self.caliper_args += [ str1, str2 ]
  self.caliper_args.extend([str3, str4])
  ...
  ...
  # eventually deep in the callstack, a maybe_list(caliper_args) is called.

For whatever reason, we used "append" and the target_class is a list (even though
it should be a single string argument). But anyhow, it works, since the it was an
assignment "self.caliper_args = self.context.options.target_class"

Now the change introduced in the RB, while keeping the target still a list, it
changes the line "self.caliper_args = self.context.options.target_class" to

  self.args.insert(0, self.get_options().target)

Note even though it's called "target", it's actually an list. Thus we're inserting
a list as an element into a list. Later the maybe_list failed.

- also fixed the pants.ini benchmark setting name mismatch.

Testing Done:
local benchmark run worked.

CI (with all 3 commits) is baking: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/39519055

Reviewed at https://rbcommons.com/s/twitter/r/1254/

Coverage Stats

11791 of 18284 relevant lines covered (64.49%)

1.29 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2422.1	30 Oct 2014 08:00PM UTC	0	64.49	Travis Job 2422.1
2	2422.2	30 Oct 2014 07:56PM UTC	0	64.49	Travis Job 2422.2

Source Files on build 2422

Detailed source file information is not available for this build.

pantsbuild / pants / 2422
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2422

pantsbuild / pants / 2422 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2422

pantsbuild / pants / 2422
0%
main: 93%

README BADGES
x