• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Instagram / IGListKit / 1844
100%

Build:
DEFAULT BRANCH: master
Ran 22 Sep 2017 01:41AM UTC
Jobs 3
Files 90
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1844

push

travis-ci

facebook-github-bot
<a href="https://github.com/Instagram/IGListKit/commit/b2860c360">Fix scrollToObject: bug when scrolling to bottom with content inset

Summary:
This has been around forever, surprised we&#39;ve never run into it. Instagram doesn&#39;t really use the `bottom` position except for one place that is already at the bottom of a view. Looks like this bug has just been hanging around quietly for ages.

`UIScrollView` takes into account the content inset when changing the content offset. Doing math w/ the inset is both useless and incorrect.

Issue fixed: #932

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn&#39;t tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
Closes https://github.com/Instagram/IGListKit/pull/940

Differential Revision: D5881117

Pulled By: rnystrom

fbshipit-source-id: </a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/5c9af4b6f">5c9af4b6f</a>

11140 of 11431 relevant lines covered (97.45%)

866.62 hits per line

Jobs
ID Job ID Ran Files Coverage
10 1844.10 (DESTINATION="OS=10.1,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO", Gemfile) 22 Sep 2017 01:41AM UTC 0
97.46
Travis Job 1844.10
11 1844.11 (DESTINATION="OS=10.2,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO", Gemfile) 22 Sep 2017 01:48AM UTC 0
97.46
Travis Job 1844.11
12 1844.12 (DESTINATION="OS=10.3.1,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO", Gemfile) 22 Sep 2017 01:46AM UTC 0
97.46
Travis Job 1844.12
Source Files on build 1844
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1844
  • b2860c36 on github
  • Prev Build on master (#1835)
  • Next Build on master (#1853)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc