Instagram / IGListKit / 1765
100%

DEFAULT BRANCH: master
Ran
Jobs 4
Files 88
Run time 368min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1765

push

travis-ci

Facebook Github Bot 
<a href="https://github.com/Instagram/IGListKit/commit/<a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/f79516ee66e185586d9a04c280b09bf5575d4d64">f79516ee6<a href="https://github.com/Instagram/IGListKit/commit/f79516ee66e185586d9a04c280b09bf5575d4d64">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/Instagram/IGListKit/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/Instagram/IGListKit/commit/f79516ee66e185586d9a04c280b09bf5575d4d64&quot;&gt;f79516ee6&lt;/a&gt;&lt;a href=&quot;https://github.com/Instagram/IGListKit/commit/f79516ee66e185586d9a04c280b09bf5575d4d64&quot;&gt;&amp;quot;&amp;gt;Proper support vertical and bottom positions in IGListAdapter scrollToObject: API

Summary:
I simply wrote failing tests for `scrollToObject` API for the `ScrollPosition` parameter and then fixed the code.

If we agree that these tests are correct, I don&amp;amp;#39;t mind suggesting a fix for it. I think it&amp;amp;#39;s the `indexPath`&amp;amp;#39;s row that is hardcoded to `0` that needs to be changed depending on the `scrollPosition` desired. (Done!)

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn&amp;amp;#39;t tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/861

Differential Revision: D5678607

Pulled By: rnystrom

fbshipit-source-id: &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/Instagram/IGListKit/commit/</a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/<a class="double-link" href="https://github.com/Instagram/IGListKit/commit/ab902b58fe70667ef6133cb05569a2223a668243">ab902b58f</a>">ab902b58f</a><a href="https://github.com/Instagram/IGListKit/commit/f79516ee66e185586d9a04c280b09bf5575d4d64">">ab902b58f</a>

10675 of 10964 relevant lines covered (97.36%)

1179.85 hits per line

Jobs
ID Job ID Ran Files Coverage
9 1765.9 (DESTINATION="OS=10.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" RUN_UI_TESTS="NO" POD_LINT="NO", Gemfile) 0
97.37
 Travis Job 1765.9
10 1765.10 (DESTINATION="OS=10.1,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO", Gemfile) 0
97.37
 Travis Job 1765.10
11 1765.11 (DESTINATION="OS=10.2,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO", Gemfile) 0
97.37
 Travis Job 1765.11
12 1765.12 (DESTINATION="OS=10.3.1,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO", Gemfile) 0
97.37
 Travis Job 1765.12
Source Files on build 1765
Detailed source file information is not available for this build.