Instagram / IGListKit / 1716

100%

Build Type

push

travis-ci

Committed by Facebook Github Bot

Commit Message

<a href="https://github.com/Instagram/IGListKit/commit/<a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/e8ddaf87406b0b13f2408f557101ffdc5b95c2ac">e8ddaf874<a href="https://github.com/Instagram/IGListKit/commit/e8ddaf87406b0b13f2408f557101ffdc5b95c2ac">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/Instagram/IGListKit/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/Instagram/IGListKit/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/Instagram/IGListKit/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/Instagram/IGListKit/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/Instagram/IGListKit/commit/e8ddaf87406b0b13f2408f557101ffdc5b95c2ac&quot;&gt;e8ddaf874&lt;/a&gt;&lt;a href=&quot;https://github.com/Instagram/IGListKit/commit/e8ddaf87406b0b13f2408f557101ffdc5b95c2ac&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/Instagram/IGListKit/commit/e8ddaf87406b0b13f2408f557101ffdc5b95c2ac&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a href=&amp;amp;amp;quot;https://github.com/Instagram/IGListKit/commit/&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/Instagram/IGListKit/commit/e8ddaf87406b0b13f2408f557101ffdc5b95c2ac&amp;amp;quot;&amp;amp;gt;e8ddaf874&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/Instagram/IGListKit/commit/e8ddaf87406b0b13f2408f557101ffdc5b95c2ac&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;quot;&amp;amp;amp;gt;Fix CollectionView scroll behaviour when section is empty

Summary:
Issue fixed: When a section is empty (0 cells) but has a header/footer supplementary views, calling `scrollToObject:supplementaryKinds:scrollDirection:scrollPosition:animated` wouldn&amp;amp;amp;amp;#39;t do anything as the method implementation has an early return if the section doesn&amp;amp;amp;amp;#39;t have any cells:
![screen shot 2017-06-15 at 14 07 18](https://user-images.githubusercontent.com/978865/27195239-fd86401e-51d3-11e7-8630-a018fbba6858.png)

As the section does have supplementary views and is displayed on screen, there&amp;amp;amp;amp;#39;s no reason not to scroll to it. This minor change fixes this detail.

Change in internal implementation of one method - all current tests pass. No tests added.

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn&amp;amp;amp;amp;#39;t tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/808

Differential Revision: D5353285

Pulled By: rnystrom

fbshipit-source-id: &amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/Instagram/IGListKit/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; hre</a>f=&quot;https://github.com/Instagram/IGListKit/commit/</a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/<a class="double-link" href="https://github.com/Instagram/IGListKit/commit/2b6700f98f7d38716d655dfecceb0353d65ef681">2b6700f98</a>">2b6700f98</a>">2b6700f98</a><a href="https://github.com/Instagram/IGListKit/commit/e8ddaf87406b0b13f2408f557101ffdc5b95c2ac">">2b6700f98</a>

Run Details

10628 of 10917 relevant lines covered (97.35%)

1175.52 hits per line