Instagram / IGListKit / 1697

100%

Build Type

push

travis-ci

Committed by Facebook Github Bot

Commit Message

<a href="https://github.com/Instagram/IGListKit/commit/<a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/9e312275c339925aa6e8b85cf3e3d4bec1a44f7c">9e312275c<a href="https://github.com/Instagram/IGListKit/commit/9e312275c339925aa6e8b85cf3e3d4bec1a44f7c">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/Instagram/IGListKit/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/Instagram/IGListKit/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/Instagram/IGListKit/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/Instagram/IGListKit/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/Instagram/IGListKit/commit/9e312275c339925aa6e8b85cf3e3d4bec1a44f7c&quot;&gt;9e312275c&lt;/a&gt;&lt;a href=&quot;https://github.com/Instagram/IGListKit/commit/9e312275c339925aa6e8b85cf3e3d4bec1a44f7c&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/Instagram/IGListKit/commit/9e312275c339925aa6e8b85cf3e3d4bec1a44f7c&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a href=&amp;amp;amp;quot;https://github.com/Instagram/IGListKit/commit/&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/Instagram/IGListKit/commit/9e312275c339925aa6e8b85cf3e3d4bec1a44f7c&amp;amp;quot;&amp;amp;gt;9e312275c&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/Instagram/IGListKit/commit/9e312275c339925aa6e8b85cf3e3d4bec1a44f7c&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;quot;&amp;amp;amp;gt;Add horizontal scrolling support to IGListCollectionViewLayout

Summary:
Issue fixed: #752

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn&amp;amp;amp;amp;#39;t tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)

This PR generalizes the layout logic in `IGListCollectionViewLayout.mm` to handle horizontally scrolling layouts, mainly by generalizing references to `width`, `height`, `x` and `y` to take scrolling direction into account. This changes the signature of `IGListCollectionViewLayout.init` as well as the names of a few properties, so it would be a breaking change.

I added a couple of unit tests specifically for horizontal layouts -- but held off from adding a horizontal version of *every* unit test for this class, as it would basically double the number of tests. But if you want that, just let me know and I&amp;amp;amp;amp;#39;m happy to do it.

Also let me know if you want me to add a demo VC to the Examples project that uses this new horizontal flow layout -- I have some demo code handy (I used it for testing), but didn&amp;amp;amp;amp;#39;t want to clutter up the PR if you didn&amp;amp;amp;amp;#39;t want/need it.
Closes https://github.com/Instagram/IGListKit/pull/857

Reviewed By: ryanolsonk

Differential Revision: D5547266

Pulled By: rnystrom

fbshipit-source-id: &amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/Instagram/IGListKit/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; hre</a>f=&quot;https://github.com/Instagram/IGListKit/commit/</a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/<a class="double-link" href="https://github.com/Instagram/IGListKit/commit/6094c45069fc265273d0f95c296fa78e47470384">6094c4506</a>">6094c4506</a>">6094c4506</a><a href="https://github.com/Instagram/IGListKit/commit/9e312275c339925aa6e8b85cf3e3d4bec1a44f7c">">6094c4506</a>

Run Details

10576 of 10837 relevant lines covered (97.59%)

1167.32 hits per line