207
61%
master: 75%

Ran 29 Sep 2014 11:37PM UTC

Jobs 7

Files 74

Run time 14min

Badge

Embed ▾

pending completion

Build # 207

Build Type

push

travis-ci

Committed by

tych0

Commit Message

Fix spurious WindowErrors in logs

When a window is destoryed, it gives both UmmapNotify and DestroyNotify events.
Previously, when we received a DestroyNotify we would try and issue an Unmap
for it (since unmanage() tried to unmap and withdraw windows). Obviously, you
can't unmap a window that has been destroyed and doesn't exist, so this was
wrong; with this patch we only unmap windows that have sent UnmapNotify.

Further, when we unmap windows that are going to be destroyed (as in most cases
when we receive an UnmapNotify just before a DestroyNotify), we could be trying
to unmap a window that doesn't exist. This commit switches property setting and
unmapping to using checked requests, so as to fail immediately (and not get
some WindowError in the queue). This allows us to catch the WindowErrors where
we expect them, instead of just getting them dumped in the catch-all, thus
cleaning up the extra log noise.

Closes #510

Run Details

5183 of 8646 relevant lines covered (59.95%)

4.18 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	207.1 (EVENTLOOP=trollius)	29 Sep 2014 11:38PM UTC	74	59.73	Travis Job 207.1
2	207.2 (EVENTLOOP=trollius)	29 Sep 2014 11:37PM UTC	74	59.77	Travis Job 207.2
3	207.3 (EVENTLOOP=trollius)	29 Sep 2014 11:37PM UTC	74	59.73	Travis Job 207.3
4	207.4 (EVENTLOOP=trollius)	29 Sep 2014 11:37PM UTC	74	59.7	Travis Job 207.4
5	207.5 (EVENTLOOP=tulip)	29 Sep 2014 11:40PM UTC	74	59.69	Travis Job 207.5
6	207.6 (EVENTLOOP=asyncio)	29 Sep 2014 11:43PM UTC	74	59.69	Travis Job 207.6
7	207.7 (EVENTLOOP=trollius)	29 Sep 2014 11:50PM UTC	74	59.9	Travis Job 207.7

Source Files on build 207

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

qtile / qtile / 207
61%
master: 75%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 207

qtile / qtile / 207 61% master: 75%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 207

qtile / qtile / 207
61%
master: 75%

README BADGES
x