1688
100%

Ran 03 Aug 2017 01:30PM UTC

Jobs 4

Files 87

Run time 4min

Badge

Embed ▾

pending completion

Build # 1688

Build Type

push

travis-ci

Committed by

facebook-github-bot

Commit Message

<a href="https://github.com/Instagram/IGListKit/commit/85afdfa54">Make explicit `IGListDiffable` protocol requirement

Summary:
While the CocoaDocs for the [IGListDiffable](https://instagram.github.io/IGListKit/Protocols/IGListDiffable.html) state that IGListDiffable objects should not mutate their `diffIdentifier` that requirement is not clear in this guide.

This is a documentation only PR.

Issue fixed: #880

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn&#39;t tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/881

Reviewed By: ryanolsonk

Differential Revision: D5547277

Pulled By: rnystrom

fbshipit-source-id: </a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/68d6f18f9">68d6f18f9</a>

Run Details

10304 of 10559 relevant lines covered (97.58%)

1175.33 hits per line

Jobs

ID	Job ID	Ran	Coverage
9	1688.9 (DESTINATION="OS=10.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" RUN_UI_TESTS="NO" POD_LINT="NO")	03 Aug 2017 01:30PM UTC	97.59	Travis Job 1688.9
10	1688.10 (DESTINATION="OS=10.1,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO")	03 Aug 2017 01:34PM UTC	97.59	Travis Job 1688.10
11	1688.11 (DESTINATION="OS=10.2,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO")	03 Aug 2017 01:35PM UTC	97.59	Travis Job 1688.11
12	1688.12 (DESTINATION="OS=10.3.1,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO")	03 Aug 2017 01:34PM UTC	97.59	Travis Job 1688.12

Source Files on build 1688

Detailed source file information is not available for this build.

Instagram / IGListKit / 1688
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1688

Instagram / IGListKit / 1688 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1688

Instagram / IGListKit / 1688
100%

README BADGES
x