Instagram / IGListKit / 1644

100%

push

travis-ci

<a href="https://github.com/Instagram/IGListKit/commit/<a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/1d773aa533a09ded6548fcfb42dec5070b825221">1d773aa53<a href="https://github.com/Instagram/IGListKit/commit/1d773aa533a09ded6548fcfb42dec5070b825221">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/Instagram/IGListKit/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/Instagram/IGListKit/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/Instagram/IGListKit/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/Instagram/IGListKit/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/Instagram/IGListKit/commit/1d773aa533a09ded6548fcfb42dec5070b825221&quot;&gt;1d773aa53&lt;/a&gt;&lt;a href=&quot;https://github.com/Instagram/IGListKit/commit/1d773aa533a09ded6548fcfb42dec5070b825221&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/Instagram/IGListKit/commit/1d773aa533a09ded6548fcfb42dec5070b825221&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a href=&amp;amp;amp;quot;https://github.com/Instagram/IGListKit/commit/&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/Instagram/IGListKit/commit/1d773aa533a09ded6548fcfb42dec5070b825221&amp;amp;quot;&amp;amp;gt;1d773aa53&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/Instagram/IGListKit/commit/1d773aa533a09ded6548fcfb42dec5070b825221&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;quot;&amp;amp;amp;gt;RFC: Diff in the background

Summary:
Experimenting with a new change. We have observed instances of very large (3k+) lists stalling, even on modern devices. This is especially noticeable if the models being diffed are:

- Immutable
- `performUpdates:` often and models are alloc/init&amp;amp;amp;amp;#39;d each time
- The `isEqualToDiffableObject:` is sort of expensive (many `-[NSString isEqualToString:]` across thousands of models or something)

Instead of just rolling this out, I plan on experimenting with results and seeing how much of a performance and stability boost we gain w/ this. Things to measure:

- Scroll performance
- CPU stalls
- WatchDog kills on older devices
Closes https://github.com/Instagram/IGListKit/pull/841

Reviewed By: amonshiz

Differential Revision: D5364127

Pulled By: rnystrom

fbshipit-source-id: &amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/Instagram/IGListKit/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;http</a>s://github.com/Instagram/IGListKit/commit/</a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/<a class="double-link" href="https://github.com/Instagram/IGListKit/commit/31d50d2e4b3c7c73584d6ec521a9047efd83f315">31d50d2e4</a>">31d50d2e4</a>">31d50d2e4</a><a href="https://github.com/Instagram/IGListKit/commit/1d773aa533a09ded6548fcfb42dec5070b825221">">31d50d2e4</a>

10145 of 10402 relevant lines covered (97.53%)

493.61 hits per line