Instagram / IGListKit / 1605
100%

DEFAULT BRANCH: master
Ran
Jobs 4
Files 87
Run time 9min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1605

push

travis-ci

facebook-github-bot 
<a href="https://github.com/Instagram/IGListKit/commit/<a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/<a class="double-link" href="https://git"><a class=hub.com/Instagram/IGListKit/commit/d0253b705ab87c99a4de209436fbc66733287994">d0253b705<a href="https://github.com/Instagram/IGListKit/commit/d0253b705ab87c99a4de209436fbc66733287994">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/Instagram/IGListKit/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/Instagram/IGListKit/commit/d0253b705ab87c99a4de209436fbc66733287994&quot;&gt;d0253b705&lt;/a&gt;&lt;a href=&quot;https://github.com/Instagram/IGListKit/commit/d0253b705ab87c99a4de209436fbc66733287994&quot;&gt;&amp;quot;&amp;gt;Don&amp;amp;#39;t assert indexForCell: API when cell isn&amp;amp;#39;t visible

Summary:
Noticed this randomly debugging. Say you have a completion block that finishes after some async task happens. If you scroll the cell off screen it will return `nil` for `-[UICollectionView indexPathForCell:]`, and the assert will fail (unless the SC is at 0). Quiet some asserts.
Closes https://github.com/Instagram/IGListKit/pull/824

Differential Revision: D5303432

Pulled By: rnystrom

fbshipit-source-id: &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/Instagram/IGListKit/commit/</a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/<a class="double-link" href="https://github.com/Instagram/IGListKit/commit/64432c43f46d33ce052e6f4fedc094c1fc1f04e1">64432c43f</a>">64432c43f</a><a href="https://github.com/Instagram/IGListKit/commit/d0253b705ab87c99a4de209436fbc66733287994">">64432c43f</a>

10102 of 10356 relevant lines covered (97.55%)

495.49 hits per line

Jobs
ID Job ID Ran Files Coverage
9 1605.9 (DESTINATION="OS=10.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" RUN_UI_TESTS="NO" POD_LINT="NO") 0
97.55
 Travis Job 1605.9
10 1605.10 (DESTINATION="OS=10.1,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO") 0
97.55
 Travis Job 1605.10
11 1605.11 (DESTINATION="OS=10.2,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO") 0
97.55
 Travis Job 1605.11
12 1605.12 (DESTINATION="OS=10.3.1,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO") 0
97.55
 Travis Job 1605.12
Source Files on build 1605
Detailed source file information is not available for this build.