grpc / grpc-java / 6527

89%

master: 89%

push

travis-ci

netty: Eagerly create SslContext

Creating the SslContext can throw, generally due to broken ALPN. We want
that to propagate to the caller of build(), instead of within the
channel where it could easily cause hangs.

We still delay creation until actual build() time, since TLS is not
guaranteed to work and the application may be configuring plaintext or
similar later before calling build() where SslContext is unnecessary.

The only externally-visible change should be the exception handling.
I'd add a test, but the things throwing are static and trying to inject
them would be pretty messy.

Fixes #2599

5 of 5 new or added lines in 1 file covered. (100.0%)

9121 of 10235 relevant lines covered (89.12%)

0.89 hits per line