Instagram
/
IGListKit
/
1451
100%
|
Ran
|
Jobs
4
|
Files
87
|
Run time
26s
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
Facebook Github Bot
Move section index to property Summary: This pull request removes the `sectionForSectionController:` method from the `IGListCollectionContext` protocol so that the protocol is exclusively for presentation methods. This should not add new functionality, but rather makes the index directly accessible on the section controllers themselves. This change makes sense because at no time will there be an update to the list that the list adapter is unaware of and so it will always be able to set and update any indexes for a section controller that has changed. Issue fixed: #609 - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [X] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/671 Reviewed By: jessesquires Differential Revision: D4942159 Pulled By: amonshiz fbshipit-source-id: d648cfdd3
10040 of 10286 relevant lines covered (97.61%)
489.55 hits per line
Jobs
Source Files on build 1451
Detailed source file information is not available for this build.