1085
100%

Ran 05 Mar 2017 12:21AM UTC

Jobs 4

Files 24

Run time 11min

Badge

Embed ▾

pending completion

Build # 1085

Build Type

push

travis-ci

Committed by

facebook-github-bot

Commit Message

Test and fix layout fitting width and inset sections with newline

Summary:
Fixes internally reported issue where the layout was new lining a section that had proper width math. Also, when inset sections were all on the same line, the max height added inset for each section, causing the newline to be too low.

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
Closes https://github.com/Instagram/IGListKit/pull/522

Reviewed By: jessesquires

Differential Revision: D4655554

Pulled By: rnystrom

fbshipit-source-id: 5e759451e

Run Details

3106 of 3149 relevant lines covered (98.63%)

1138.47 hits per line

Jobs

ID	Job ID	Ran	Coverage
5	1085.5 (DESTINATION="OS=9.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" RUN_UI_TESTS="NO" POD_LINT="NO")	05 Mar 2017 12:21AM UTC	98.51	Travis Job 1085.5
9	1085.9 (DESTINATION="OS=10.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" RUN_UI_TESTS="NO" POD_LINT="NO")	05 Mar 2017 12:25AM UTC	98.63	Travis Job 1085.9
10	1085.10 (DESTINATION="OS=10.1,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO")	05 Mar 2017 12:25AM UTC	98.63	Travis Job 1085.10
11	1085.11 (DESTINATION="OS=10.2,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="YES" POD_LINT="NO")	05 Mar 2017 12:33AM UTC	98.63	Travis Job 1085.11

Source Files on build 1085

Detailed source file information is not available for this build.

Instagram / IGListKit / 1085
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1085

Instagram / IGListKit / 1085 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1085

Instagram / IGListKit / 1085
100%

README BADGES
x