3081
88%

Ran 23 Feb 2017 09:48PM UTC

Jobs 4

Files 44

Run time 1min

Badge

Embed ▾

pending completion

Build # 3081

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix flaky test TestInboundConnection (#588)

TestInboundConnection verifies that the InboundConnection returns the
right connection. However when the test was run with a relay, there was
a race that could cause the test to fail.

We have a server channel and a relay, and the test called the server
through the relay, so we had:
server --C1--> relay --C?--> server

The relay had a race between whether it would use the incoming
connection from the server to send the call back, or creating a new
connection. When the connection was reused, the test passed since the
relay responds with the host:port on inbound connections. However when
the relay creates a new connection, it hides the host:port on outbound
connections, and so the server would see an ephemeral host:port and this
would cause the test to fail:
https://travis-ci.org/uber/tchannel-go/jobs/204481657

Updated the test to use a separate channel for making calls instead of
a single channel calling itself. Also disable relays to avoid races.

Run Details

4282 of 4879 relevant lines covered (87.76%)

12113.75 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3081.1	23 Feb 2017 09:48PM UTC	87.31	Travis Job 3081.1
2	3081.2	23 Feb 2017 09:48PM UTC	86.75	Travis Job 3081.2
3	3081.3	23 Feb 2017 09:47PM UTC	87.14	Travis Job 3081.3
4	3081.4	23 Feb 2017 09:49PM UTC	87.18	Travis Job 3081.4

Source Files on build 3081

Detailed source file information is not available for this build.

uber / tchannel-go / 3081
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3081

uber / tchannel-go / 3081 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3081

uber / tchannel-go / 3081
88%

README BADGES
x