iotaledger / iota

67%

Build Type

push

github

Committed by web-flow

Commit Message

fix(graphql-rpc): include all dryRunTransactionBlock argument types in query cost evaluation (#11583)

# Description of change

With #9152, we only considered `txBytes` as the eligible argument to
contribute to tx-payload size, but clearly this is not the case if also
`txMeta` is provided in `Query.dryRunTransactionBlock`. It is reminded
that `txBytes` might represent either
[TransactionData](https://iotaledger.github.io/iota/iota_types/transaction/enum.TransactionData.html)
(the richer value) or
[TransactionKind](https://iotaledger.github.io/iota/iota_types/transaction/enum.TransactionKind.html).
If the user passes `txMeta` the latter is assumed. Thus, including
`txMeta` is an eligible candidate for the transaction size.

This patch extends the cost evaluation for arguments pertaining to
transaction execution and fixes this issue.

## Links to any relevant issues

Fixes #11578 

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)

Also ran manual tests with the query reported in the parent issue.

### Infrastructure QA (only required for crates that are maintained by
@iotaledger/infrastructure)

This patch does not affect ingestion or the API.

### Release Notes

- [x] GraphQL: Fixes an issue where passing `txMeta` input in
`Query.dryRunTransactionBlock` could lead to errors due to query limit
checks.

---------

Co-authored-by: Sergiu Popescu <44298302+sergiupopescu199@users.noreply.github.com>
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>

Coverage Stats

0 of 19 new or added lines in 2 files covered. (0.0%)

3728 existing lines in 57 files now uncovered.

152092 of 227463 relevant lines covered (66.86%)

462917.77 hits per line