iotaledger / iota

66%

Build Type

push

github

Committed by web-flow

Commit Message

upstream(graphql): deduplicate configs and clap args, add flag to skip db compatibility (#9261)

# Description of change

Original descriptions:

> Avoid duplicating fields for configs that are accepted as flags from
the command-line and can also be read from TOML file. Use the same
struct for both purposes but deocrate it with both clap and serde (or
GraphQLConfig) annotations so that it can serve both purposes.

> Add a flag to optionally skip database migration compatibility checks.
This is helpful when trying to connect a local build up to a production
database to test a specific change, even if you are aware that other
queries may not be compatible.
To accommodate this change, the compatibility check was also moved into
`ServerBuilder` where the config is readily available. This also
slightly simplifies the `Server` itself, which no longer needs to hold
onto its own instance of the `Db`.

## Links to any relevant issues

fixes https://github.com/iotaledger/iota/issues/9217

## How the change has been tested

Comparing `cargo run --bin iota-graphql-rpc -- start-server --help`
before and after the change.

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)

### Infrastructure QA (only required for crates that are maintained by
@iotaledger/infrastructure)

- [ ] Synchronization of the indexer from genesis for a network
including migration objects.
- [ ] Restart of indexer synchronization locally without resetting the
database.
- [ ] Restart of indexer synchronization on a production-like database.
- [x] Deployment of services using Docker. - Tested if graphql starts up
successfully with `pg-services-local`
- [ ] Verification of API backward compatibility.

Run Details

2 of 22 new or added lines in 4 files covered. (9.09%)

1361 existing lines in 35 files now uncovered.

236465 of 358522 relevant lines covered (65.96%)

2354899.45 hits per line