decentraland / catalyst-storage

95%

push

github

fix: make S3 retrieve error logging actionable (#107)

* fix: make S3 retrieve error logging actionable

retrieve() logged any non-NotFound error from headObject as a bare
logger.error(error). For a 403 on a HEAD that produces "Forbidden: null"
with no key, which is unhelpful. Now it logs the failing key plus the S3
code/statusCode, and surfaces 403 as a warning with a hint (missing
s3:ListBucket makes a missing key return 403 instead of 404, or it is a
genuine access denial) rather than an error.

* refactor: drop redundant spread when logging S3 retrieve errors

109 of 127 branches covered (85.83%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

378 of 387 relevant lines covered (97.67%)

37.77 hits per line