decentraland / catalyst-storage

95%

main: 95%

push

github

fix: remove the partial .gzip when compression fails (#106)

* fix: remove the partial .gzip when compression fails

gzipCompressFile destroyed the streams in a finally but never removed the
output on error, so a read/write/gzip failure mid-compression left a
truncated .gzip on disk. Because retrieve/fileInfo check the .gzip first,
that partial file shadows the good uncompressed file and is served as
corrupt content on later reads.

Wrap the compression in a try/catch that unlinks the output on any failure
(and await the bad-ratio unlink instead of fire-and-forget). Adds tests for
the success, bad-ratio, and failure paths.

* test+fix: log compression cleanup failures and clarify failure test

- Surface unlink failures during compression cleanup at warn level (via an
  optional logger threaded from the folder storage) instead of swallowing
  them entirely; ENOENT is still ignored.
- Rename/comment the failure test to make explicit that the missing source
  triggers a read-open error exercising the shared catch/cleanup path.

106 of 122 branches covered (86.89%)

Branch coverage included in aggregate %.

17 of 19 new or added lines in 2 files covered. (89.47%)

375 of 384 relevant lines covered (97.66%)

37.95 hits per line