dart-lang / tools

94%

LAST BUILD ON BRANCH main

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• add_issues_links
• badges
• ci_cleanup
• cleanup_silly
• cli-config-coverage
• cli-config-dev
• cli_config-sync
• cli_config_docs
• cov_corner_case
• cov_filter_ignored
• cov_iso_hang
• cov_pub
• cov_rpc_error
• cov_workspaces
• cov_yaml
• coverage-flags-yaml
• coverage_update_mocks
• covpubprep
• dependabot/github_actions/actions/checkout-3.5.0
• dependabot/github_actions/actions/checkout-3.5.2
• dependabot/github_actions/actions/checkout-3.5.3
• dependabot/github_actions/actions/checkout-3.6.0
• dependabot/github_actions/actions/checkout-4.1.0
• dependabot/github_actions/actions/checkout-4.1.1
• dependabot/github_actions/actions/checkout-4.1.2
• dependabot/github_actions/actions/checkout-4.1.4
• dependabot/github_actions/coverallsapp/github-action-2.0.0
• dependabot/github_actions/coverallsapp/github-action-2.1.2
• dependabot/github_actions/coverallsapp/github-action-2.2.0
• dependabot/github_actions/coverallsapp/github-action-2.2.1
• dependabot/github_actions/coverallsapp/github-action-2.2.3
• dependabot/github_actions/dart-lang/setup-dart-1.6.0
• dependabot/github_actions/dart-lang/setup-dart-1.6.2
• dependabot/github_actions/dart-lang/setup-dart-1.6.4
• dependabot/github_actions/github-actions-130e275bbf
• dependabot/github_actions/github-actions-4bbd769b2c
• dependabot/github_actions/github-actions-5cd08569fb
• dependabot/github_actions/github-actions-6a5076a08d
• dependabot/github_actions/github-actions-821e67d316
• dependabot/github_actions/github-actions-9c54b75f35
• dependabot/github_actions/github-actions-aa3137d618
• dependabot/github_actions/github-actions-ad14d08c93
• dependabot/github_actions/github-actions-e6ee9d7de3
• dependabot/github_actions/github-actions-edf2abb101
• dependabot/github_actions/github-actions-fa0ebbeeaa
• dependabot/github_actions/github-actions-fae3105be2
• dependabot/github_actions/github-actions-fc897e6b79
• deploy_markdown_playground
• dropped_collections
• feat/language-version-package
• feat/preserve-fenced-code-block-metadata
• feature/fail_under
• fix-line-ending-bug
• fix-perform-edit
• fix-windows
• fix520
• fix685
• fix_analysis
• fix_deploy_markdown
• fix_lints
• fix_markdown
• fix_single_element_map
• have-ci-checks-run-for-all-PR-branches
• issue_links
• kevmoo-patch-1
• lint_cleanup
• main
• markdown
• markdown/fenced-code-block-indent-handling
• markdown_example_cleanup
• markdown_fix_crash_test
• markdown_fix_doc_commetns
• md-html-multiline-comment
• merge-coverage-package
• merge-markdown-package
• merge-yaml_edit-package
• more_cleanup
• non-string-map-keys
• normalize_workflows
• optional-string-valid-values
• patch-exception-on-616
• patch-tests-for-588-2
• remove-pub-run
• remove_options_dups
• resolve-paths-windows
• revert-2295-revert-2340a3a
• revert-2340a3a
• setup_dart
• sortReadme
• string-list
• update_example
• update_markdown_example_html
• update_pkg_cli_config
• v0.1.0
• validate_setup_dart
• vm_service_15
• yaml_edit-crash-test
• yaml_edit_2.2.4

Build # 23100011580

Build Type

push

github

Committed by web-flow

Commit Message

Optimize LineScanner newline detection and fix backwards position bug (#2342)

- Replaced RegExp reliance in `LineScanner` (such as `_newlinesIn`) with manual code unit iteration to avoid unnecessary allocations and scanning overhead.
- Improved performance in core loop methods (`readChar`, `scanChar`, `scan`) which directly cascades to `SpanScanner`.
- Fixed a `RangeError` bug when setting `position` backwards across a `\r\n` boundary by completely rewriting the bounded boundary-checking loop.
- Added a benchmark script to measure raw throughput improvements.
- Added comprehensive test coverage in `line_scanner_test.dart` for backwards boundary traversal.

### Performance Comparison

| Benchmark Target | Before (us) | After (us) | Change (%) | Status |
| :--- | :--- | :--- | :--- | :--- |
| **StringScanner readChar** | 16,790 | 16,430 | -2.1% | Minor Improv. |
| **LineScanner readChar** | 57,328 | 55,491 | -3.2% | Minor Improv. |
| **SpanScanner readChar** | 49,400 | 50,158 | +1.5% | Slight Regression |
| **StringScanner scan** | 1,103,350 | 1,102,107 | -0.1% | Negligible |
| **LineScanner scan** | 2,185,230 | 1,338,592 | **-38.7%** | **Major Win** |
| **SpanScanner scan** | 1,209,363 | 1,198,558 | -0.9% | Minor Improv. |

Run Details

696 of 741 relevant lines covered (93.93%)

4.08 hits per line