apolloconfig / agollo

76%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• add-close-method-to-stop-polling
• bugfix/nonretry
• chore/comment_cn
• chore/format
• chore/gotool
• chore/license
• chore/readme_cn
• copilot/fix-343
• dependabot/go_modules/develop/github.com/agiledragon/gomonkey/v2-2.12.0
• dependabot/go_modules/develop/github.com/agiledragon/gomonkey/v2-2.13.0
• dependabot/go_modules/develop/github.com/spf13/viper-1.8.1
• develop
• f-client-label
• failfast-http-err-status
• feat/log
• feature-not-modified-log
• feature/changeOrg
• feature/fixGetSlice
• feature/moveOrg
• fix-internalip
• fix-typo
• fix/async_notify
• fix/close_bug
• fix/error-log
• fix/fix_sync
• fix/getconfig
• fix/sync_supplement
• hotfix/fixDoc
• hotfix/fixGetBoolValue
• log
• master
• must_connect
• refactor/code-optimisation
• refs/pull/284/merge
• update/duration
• versionUpdate
• wh/repository_getYaml

Build # 18182348507

Build Type

push

github

Committed by web-flow

Commit Message

Fix infinite loop when consecutive releases return 304 Not Modified responses (#344)

* Initial plan

* Initial analysis and plan for fixing agollo infinite loop issue

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Fix infinite loop issue when consecutive releases return 304 responses

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Refactor syncWithNamespaceAndDetectNotModified to properly wrap SyncWithNamespace

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Reduce scope of modifications by using simpler flag-based approach for 304 detection

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Implement cleaner error-based approach for async config only, maintaining backward compatibility

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Implement cleaner error-based approach suggested by @nobodyiam

- Changed SyncWithNamespace signature to return (*config.ApolloConfig, error)
- Updated all call sites to handle the new signature
- Removed lastCallWasNotModified flag approach in favor of standard Go error handling
- In async.go, use `apolloConfig != nil || err == nil` to detect successful responses including 304
- All tests pass, including the critical TestApolloConfig_SyncWith304NotModified test

This is a much cleaner approach that eliminates the flag-based mechanism while maintaining backward compatibility and achieving the same result.

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Address code review feedback: fix return value and remove unused JSON files

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Simplify notification ID update logic and remove unused JSON test files

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Remove accidentally committed JSON test files

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Remove JS... (continued)

Run Details

11 of 11 new or added lines in 4 files covered. (100.0%)

1330 of 1758 relevant lines covered (75.65%)

3.62 hits per line