apolloconfig / agollo / 18182348507

76%

push

github

Fix infinite loop when consecutive releases return 304 Not Modified responses (#344)

* Initial plan

* Initial analysis and plan for fixing agollo infinite loop issue

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Fix infinite loop issue when consecutive releases return 304 responses

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Refactor syncWithNamespaceAndDetectNotModified to properly wrap SyncWithNamespace

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Reduce scope of modifications by using simpler flag-based approach for 304 detection

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Implement cleaner error-based approach for async config only, maintaining backward compatibility

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Implement cleaner error-based approach suggested by @nobodyiam

- Changed SyncWithNamespace signature to return (*config.ApolloConfig, error)
- Updated all call sites to handle the new signature
- Removed lastCallWasNotModified flag approach in favor of standard Go error handling
- In async.go, use `apolloConfig != nil || err == nil` to detect successful responses including 304
- All tests pass, including the critical TestApolloConfig_SyncWith304NotModified test

This is a much cleaner approach that eliminates the flag-based mechanism while maintaining backward compatibility and achieving the same result.

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Address code review feedback: fix return value and remove unused JSON files

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Simplify notification ID update logic and remove unused JSON test files

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Remove accidentally committed JSON test files

Co-authored-by: nobodyiam <837658+nobodyiam@users.noreply.github.com>

* Remove JS... (continued)

11 of 11 new or added lines in 4 files covered. (100.0%)

1330 of 1758 relevant lines covered (75.65%)

3.62 hits per line