DavidCain / mitoc-member / 47

Builds Branch Commit Type Ran Committer Via Coverage
47 master Correct use of `mock.patch.dict` Previously, I had falsely assumed that `mock.patch.dict` would overwrite the dict that it is mocking. This is not actually the case! Rather, the keys that are specified are *additive*. In order to achieve a comple... push DavidCain travis-ci pending completion   set done
46 master Cache pip directory between builds See: https://docs.travis-ci.com/user/caching/ We install `poetry` using `pip`, so caching pip itself will speed up the installation of `pypoetry`! In our `.travisy.yml`, we might consider installing `poetry` wi... push DavidCain travis-ci pending completion   set done
45 build_caching Testing pip + poetry caching api DavidCain travis-ci pending completion   set done
44 build_caching Cache pip directory between builds See: https://docs.travis-ci.com/user/caching/ We install `poetry` using `pip`, so caching pip itself will speed up the installation of `pypoetry`! In our `.travisy.yml`, we might consider installing `poetry` wi... push DavidCain travis-ci pending completion   set done
43 build_caching Oops - actually test caching on the right branch api DavidCain travis-ci pending completion   set done
42 master Testing pip caching api DavidCain travis-ci pending completion   set done
41 build_caching Cache pip directory between builds `poetry` still uses pip under the hood. By caching pip, we can avoid downloading packages with each build. This should speed things up considerably! See: https://docs.travis-ci.com/user/caching/ Note that the ... push DavidCain travis-ci pending completion   set done
40 master Add an extremely simple wsgi test Testing a file that's basically a single line of code is a bit contrived (especially since the true test is an end-to-end integration test that actually spins up a server with WSGI). In any case though, this at l... push DavidCain travis-ci pending completion   set done
39 master Also test behavior when Sentry not config'd This makes sure that the route works when Sentry is not configured, but the external API is down! push DavidCain travis-ci pending completion   set done
37 master Test membership without signature verification Processing memberships without verifying the CyberSource signature is unfortunately how things work in production. We support this behavior in the first place since MITOC does not actually have acce... push DavidCain travis-ci pending completion   set done
36 master Add coverage for waiver-adding route This test has a _lot_ more mocking than I would like. However, we'll soon be ripping out the direct database interaction of `mitoc-member` and replacing it with API calls. Most of the `db.<method>` invocations... push DavidCain travis-ci pending completion   set done
35 master Add test coverage for `other_verified_emails` push DavidCain travis-ci pending completion   set done
34 master Use mock.patch.object where sensible Rather than worrying about the exact import path we're mocking, I often prefer to just mock directly from an object. I think this is more readable, and also ensures that we're properly mocking the actual object. push DavidCain travis-ci pending completion   set done
32 poetry Run lint on build, also lint tests This changes the build to run `pylint` as part of each build. There's no reason that our tests should not also adhere to rules from `pylint` & `isort`! This fixes existing violations, and configures the build t... push DavidCain travis-ci pending completion   set done
30 poetry Just use `pytest` directly There's no need to add a custom `flask test` step - we can instead use `flask test` directly. push DavidCain travis-ci pending completion   set done