se-edu / addressbook-level4 / 4672

Builds Branch Commit Type Ran Committer Via Coverage
4672 getting-started-model Model: Add deleteTag(Tag) The Model API does not expose a way to delete a particular Tag entirely from the AddressBook (i.e. removing the Tag from all Persons and purging the Tag in the AddressBook's tag list). Let's add Model#deleteTag(Tag). Pull #790 web-flow travis-ci pending completion   set done
4671 getting-started-model Model: Add deleteTag(Tag) The Model API does not expose a way to delete a particular Tag entirely from the AddressBook (i.e. removing the Tag from all Persons and purging the Tag in the AddressBook's tag list). Let's add Model#deleteTag(Tag). Pull #790 web-flow travis-ci pending completion   set done
4670 master ModelManager: remove synchronization from methods Synchronized methods are only useful when multiple threads could access the same object at the same time[1]. However, when our application is run, only the JavaFX application thread should have a... push pyokagan travis-ci pending completion   set done
4669 remove-synchronized ModelManager: remove synchronization from methods Synchronized methods are only useful when multiple threads could access the same object at the same time[1]. However, when our application is run, only the JavaFX application thread should have a... Pull #905 web-flow travis-ci pending completion   set done
4668 remove-synchronized ModelManager: remove synchronization from methods Synchronized methods are only useful when multiple threads could access the same object at the same time[1]. However, when our application is run, only the JavaFX application thread should have a... Pull #905 web-flow travis-ci pending completion   set done
4667 checkstyle-singlespace checkstyle: add SingleSpaceSeparator Most of the code in our the code base only puts a single space between non-whitespace characters, "Like " + "this." It is highly likely that there will not be a case where we will need to put more than a... Pull #904 web-flow travis-ci pending completion   set done
4666 checkstyle-singlespace checkstyle: add SingleSpaceSeparator Most of our code in the code base put only a single space between non-whitespace characters, "Like " + "this." There is really no reason why code should put more than a single space between non-whitespac... Pull #904 web-flow travis-ci pending completion   set done
4664 master [#856] Remove unnecessary uses of `this` (#903) [1/2] Remove unnecessary uses of `this` [2/2] XmlAdaptedPerson#toModelType(): remove shadowing of fields push web-flow travis-ci pending completion   set done
4663 chore-no-unnecessary-this XmlAdaptedPerson#toModelType(): remove shadowing of fields The method body references the fields of XmlAdaptedPerson (`name`, `phone`, etc.), but also shadows them later on by declaring local variables with the same name. Such mixing of instance... Pull #903 web-flow travis-ci pending completion   set done
4662 chore-no-unnecessary-this Remove unnecessary uses of `this` According to our Java coding standard[1], we should only use the `this` keyword when the field is shadowed by a method or constructor parameter. So, let's remove all unnecessary uses of `this` from our code base... Pull #903 web-flow travis-ci pending completion   set done
4661 chore-no-unnecessary-this Remove unnecessary uses of `this` According to our Java coding standard[1], we should only use the `this` keyword when the field is shadowed by a method or constructor parameter. So, let's remove all unnecessary uses of `this` from our code base... Pull #903 web-flow travis-ci pending completion   set done
4660 master [#829] Update TestUtil to use filteredList (#900) Methods in TestUtil such as getMidIndex(Model), getLastIndex(Model) and getPerson(Model, Index) return the index and person based on the entire address book instead of the model's filtered list.... push web-flow travis-ci pending completion   set done
4659 829-update-testutil-to-use-filteredlist Update SelectCommandSystemTest to use methods from TestUtil Pull #900 web-flow travis-ci pending completion   set done
4658 829-update-testutil-to-use-filteredlist Merge branch 'master' into 829-update-testutil-to-use-filteredlist Pull #900 web-flow travis-ci pending completion   set done
4657 829-update-testutil-to-use-filteredlist Update SelectCommandSystemTest to use methods from TestUtil Pull #900 web-flow travis-ci pending completion   set done