cloudfoundry-incubator / service-fabrik-broker / 6044 / 5

88%

master: 88%

push

travis-ci-com

prevent accidental deletion of sfplans by users. (#1532)

* Add mcd reconciler to prevent accidental deletion of sfplans.

* Check if the corresponding sfplan needs to be deleted while deleting sfserviceinstance.

If user initiates sfplan deletion while there are sfserviceinstances existing for this plan
which are not set to be deleted. Since the deletion timestamp for the sfplan will
be set the first time user tried to delete the plan, any subsequent tries to delete the same
plan will not trigger the reconciler as the sfplan CR remains the same.
Hence, every time an sfserviceinstance is deleted, we check if the corresponding sfplan
has non-zero deletion ts, and if so perform an update on the plan to force trigger the
reconciliation. If, this is the last sfserviceinstance that belongs to the plan set to be
deleted, the reconciler will remove the finalizer and delete the sfplan. However, this logic
is only applicable to the master cluster while the sfplan flow on sister cluster pretty much
remains the same.

* Add tests to prevent accidental deletion of sfplans.

2972 of 4499 branches covered (66.06%)

Branch coverage included in aggregate %.

10257 of 12485 relevant lines covered (82.15%)

34.88 hits per line