1
100%
master: 100%

Ran 14 Mar 2022 05:13PM UTC

Files 74

Run time 1min

Badge

Embed ▾

Committed 14 Mar 2022 07:24AM UTC coverage: 94.173% (+0.1%) from 94.076%

Job # #2842.1

Build Type

push

github-actions

Committed by

ben-manes

Commit Message

Removed unneccesary top-level cache fields

Previously the cache implemented AbstractMap for the its convenient
putAll, equals, hashCode, and toString implementations. This came at
the cost of its private, unused keySet and values fields. Those Object
methods iterated over the entrySet, which returns a copy of the entry
to avoid instabiliy due to concurrent mutations. This changes to
internal iterators which avoids this unnecessary garbage creation.

Equality is a complex subject and the implementation's internal docs
now better clarify the semantics. Due to the cache potentially holding
entries that are pending removal (expiration, reference collection),
we expect that usages call Cache.cleanUp() first.

Removed an adapter for the async cache loader as not needed, dropping
two instance fields.

Simplified some serialization code by removing redundancies.

Coverage Stats

6626 of 7036 relevant lines covered (94.17%)

0.94 hits per line

ben-manes / caffeine / #2842 / 1
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #2842.1

ben-manes / caffeine / #2842 / 1 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #2842.1

ben-manes / caffeine / #2842 / 1
100%
master: 100%

README BADGES
x