kellyselden / ember-cli / 378 / 1

91%

master: 91%

push

travis-ci

<a href="https://github.com/kellyselden/ember-cli/commit/<a class=hub.com/kellyselden/ember-cli/commit/c8660a20a4116f603d1160d9bd2f06cf6a634c39">c8660a20a<a href="https://github.com/kellyselden/ember-cli/commit/c8660a20a4116f603d1160d9bd2f06cf6a634c39">&quot;&gt;Auto merge of #5036 - patocallaghan:native-dependencies, r=chadhietala

Remove native bundled dependencies

Re: https://github.com/ember-cli/ember-cli/issues/5028#issuecomment-153405634

@stefanpenner this is more a placeholder for discussion rather than a finished PR. Would appreciate you chiming in with your thoughts whether this is even on the right track or not.

## ws.js
It seems the issue of failing native dependencies has been fixed in npm 3.3.12

* Optional dependencies causing an install to fail was fixed in https://github.com/npm/npm/commit/</a><a class="double-link" href="https://github.com/kellyselden/ember-cli/commit/<a class="double-link" href="https://github.com/kellyselden/ember-cli/commit/2289234e11b30c878585aebee68d4a3a5bd63cce">2289234e1</a>">2289234e1</a><a href="https://github.com/kellyselden/ember-cli/commit/c8660a20a4116f603d1160d9bd2f06cf6a634c39"> See https://github.com/npm/npm/issues/9643 for the related issue
* running `--no-optional` should not try to install bundled dependencies in deps of deps

This means we don&#39;t need the patch for `ws.js` as `bufferutil` and `utf8-validation` will not be installed.

## patch-engine-io-client.js
it appears the reference to the `tgz` [has been removed](https://github.com/socketio/engine.io-client/pull/401/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L38) but it hasn&#39;t shipped in a release yet . Not entirely sure what we can do here though besides pushing for a release or making our own fork.

### BUT

there&#39;s a bug with the 3.3.12 version of NPM which prevents `./bin/prepare-release` from finishing. If you try to `npm uninstall` or `npm unlink` a `npm link`&#39;d global module, the build fails. This means `prepare-release` fails at the second last step when uninstalling the global `ember-cli`.  See here for more on the issue https://github.com/npm/npm/issues/9980.

We could possibly do a `which ember`, work out where the global ember is installed, and manually `rm -rf` it?

3928 of 4228 relevant lines covered (92.9%)

5677.78 hits per line