1
55%
master: 99%

Ran 15 Feb 2022 11:23AM UTC

Files 23

Run time 1min

Badge

Embed ▾

Committed 15 Feb 2022 10:18AM UTC coverage: 97.451% (-1.5%) from 98.986%

Job # #117.1

Build Type

push

php-coveralls

Committed by

zozlak

Commit Message

Only RestController can output HTTP headers and data (closes #24)

Until now data has been put to PHP output in various places which could
lead to response being send to a client prematurely. Now only the
RestController class is supposed to actually send the output. It
provides setHeader()/addHeader()/setOutput() allowing other code to
impact what will be send.

For all outputs but the one generated by the MetadataReadOnly class the
change was straightforward - instead of echo-ing the response they just
generate a string and set it using RestController::setOutput() (and a
simple util/OutputFile wrapper is used to do the same for whole files).

MetadataReadOnly required a slightly more complex approach. It must
release the database connection early so its output has to be stored
somewhere and hopefully not just as a string in memory (because output
can be really huge here). This has been solved by introducing an
internal php://temp stream which automagically stores data in memory
until they are small (PHP default is 2MB) and uses a temporary file when
they grow bigger.

Run Details

1606 of 1648 relevant lines covered (97.45%)

157.98 hits per line

acdh-oeaw / arche-core / #117 / 1
55%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #117.1

acdh-oeaw / arche-core / #117 / 1 55% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #117.1

acdh-oeaw / arche-core / #117 / 1
55%
master: 99%

README BADGES
x