wikimedia
/
parsoid
/
758
/
3
85%
master: 85%
master: 85%
|
Ran
|
Files
73
|
Run time
2s
|
Badge
Embed ▾
README BADGES
|
coverage: 83.922% (-0.02%) from 83.946%
push
travis-ci
subbussFix sol handling in separators + tag handler cleanup * Only /\n$/ puts serializer in SOL-state, not /\n\s*$/. * However, fixing this bug exposed another fairly serious one. NL constraints for various HTML tags don't indicate whether the wikitext for the HTML tags should force SOL state by stripping excess whitespace characters at the start of line. [subbu@earth lib] echo "<ul>\n<li>a</li>\n <li>b</li></ul>" | node parse --html2wt * a * b This is clearly a bug. The reason we didn't trip over it all this while is because 'make-indent-pre' stripped the excess whitespace to prevent indent-pre-ing the content. However, that is a scenario of one bug papering over another bug. * This patch also introduces a new flag in tag handlers. Tags can declare if they force SOL state on separators. This flag is used to suppress non-nl whitespace before emitting wikitext for those tags. * The fly-in-the-ointment there were some tags that have different behavior in different contexts. Ex: ";a:b" vs ";a\n:b". The <dd> tag in the second example forces SOL context but not the former. Added additional handling to deal with this scenario. However, this also led to some nice code cleanup in the tag handlers. * No net parser test changes after all these fixes. Change-Id: I7a5ccd33b
12611 of 15027 relevant lines covered (83.92%)
21111.72 hits per line
