mozilla-releng / balrog / #2808 / 1

90%

main: 89%

push

circle-ci

Fix queries for `Rules.getPotentialRequiredSignoffs` and `Releases.isMappedTo` (#2416)

As pointed out when updating to sqlalchemy 1.4, we were querying a table
but the WHERE clause was only referencing another one.

E.g. `isMappedTo` would execute `SELECT count(?) AS count_1 FROM rules, releases
WHERE rules."fallbackMapping" = ?`, which yields `SELECT statement has a
cartesian product between FROM element(s) "releases" and FROM element "rules".
Apply join condition(s) between each element to resolve.`

2524 of 2923 branches covered (86.35%)

Branch coverage included in aggregate %.

5650 of 6183 relevant lines covered (91.38%)

0.91 hits per line