1
97%
master: 97%

Ran 28 Oct 2015 09:46PM UTC

Files 87

Run time 13s

Badge

Embed ▾

Committed 28 Oct 2015 09:23PM UTC coverage: 69.227%. Remained the same

Job # 8863.1

Build Type

push

travis-ci

Committed by

nickstenning

Commit Message

Encode semicolons in query parameters

Angular 1.4.x introduced a breaking change (undocumented in the
upgrading guide as far as I can tell) to the way URL query parameters
are handled in ajax requests.

Specifically, semicolons in query parameter values are no longer encoded
by default. This causes problems for us in request urls such as

    /api/search?uri=http:%2F%2Fexample.com/?id=4;display=print

because Pyramid interprets the semicolon (correctly according to
RFC3986) as a query string delimiter.

This commit fixes the issue by overriding the default parameter
serializer (although only for the ngResource objects in the store
service) with a much more conservative one that encodes everything with
`encodeURIComponent`.

The bulk of the code here is a slightly modified version of the default
serializer used by Angular.

Coverage Stats

2578 of 3724 relevant lines covered (69.23%)

0.69 hits per line

hypothesis / h / 8863 / 1
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8863.1

hypothesis / h / 8863 / 1 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8863.1

hypothesis / h / 8863 / 1
97%
master: 97%

README BADGES
x