2
92%
main: 92%

Ran 10 Nov 2021 07:15PM UTC

Files 24

Run time 1min

Badge

Embed ▾

Committed 10 Nov 2021 07:01PM UTC coverage: 91.515%. First build

Job # GO111MODULE=off

Build Type

push

travis-ci-com

Committed by

kozlovic

Commit Message

[FIXED] Clustering: possible wrong pending count

This is a regression introduced by PR #1213 which is in v0.23.0
(the latest release).

When a queue subscription left the group and its last_sent was the
same than the group's last_sent, the remaining queue member should
have its last_sent updated. To do that, the replication of a "sent"
event for this sequence was issued, which was wrong since it would
possibly add a pending on the remaining queue sub. Moreover, this
did not account for last_sent being 0, which with the aforementioned
behavior, a "sent" of sequence 0 would be replicated causing the
remaining queue sub to show a pending_count of 1.

The fix for both wrong pending_count and original last_sent issue
is to have all nodes (leader and followers) detect that when a
member is removed, if that member's last_sent value was the one
of the queue group, then update the runtime version of the remaining
queue member.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>

Run Details

12780 of 13965 relevant lines covered (91.51%)

56499.13 hits per line

nats-io / nats-streaming-server / 2509 / 2
92%
main: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2509.2 (GO111MODULE=off)

nats-io / nats-streaming-server / 2509 / 2 92% main: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2509.2 (GO111MODULE=off)

nats-io / nats-streaming-server / 2509 / 2
92%
main: 92%

README BADGES
x