isaacgr / jaysonic / 309 / 1

95%

master: 95%

push

travis-ci-com

Task/improve server methods (#100)

* Add newly connected clients to this.clients list

    - update all previous instances to use this.clients
    - clear this.client list when _removeClients is called
    - update existing tests to use this.clients
    - add tests to verify that the list is cleared on close

* Call _removeClients on server close

* Setup listeners for ws server and clear this.clients when _removeClients called

* Remove all factory listener events

    - call clientConnected and clientDisconnected on the factory directly
    - remove .on('error') handler for factory since this seems unnecessary

* Call 'reject' on server.listen() if server receives 'error' event

* Add tests for rejecting listen() based on 'error' event

* Add 'error' event listener test

* Pass protocol instance to clientConnected

* Overwrite clientConnected and clientDisconnected methods

    - http protocol instance is based on the request, not on the connected client

* Use JsonRpcServerProtocol instance in clientConnected and clientDisconnected methods

* Update babel and jsdoc

* Add tests for clientConnected and clientDisconnected methods

* Update docs for clientConnected and clientDisconnected

232 of 254 branches covered (91.34%)

Branch coverage included in aggregate %.

689 of 716 relevant lines covered (96.23%)

44.62 hits per line