1
66%
master: 97%

Ran 29 Sep 2015 05:44PM UTC

Files 83

Run time 3s

Badge

Embed ▾

Committed 29 Sep 2015 05:36PM UTC coverage: 66.467% (-0.02%) from 66.486%

Job # 8251.1

Build Type

push

travis-ci

Committed by

nickstenning

Commit Message

Check permissions correctly when sending reply notifications

When we receive an annotation in the notification mailer, we need to
perform a set of checks:

- to determine if the annotation is a reply
- to determine who the author of the thread parent is
- to determine if we should send a reply notification to that author

In particular, we only want to send a reply notification email if the
author is going to be able to read the reply. Previously, this was done
by checking if the principals allowed by the 'read' permission included
the system principal "system.Everyone".

Unfortunately, 998347a broke this by removing normal Annotation
instances' status as a pyramid "context object", meaning that no
annotations were passing the test and no reply notification emails were
being sent.

This commit updates that permissions check. Now we:

1. Compute the set of principals of the parent annotation's author,
   using `h.auth.effective_principals`.
2. Compute the set of principals that are allowed to 'read' the reply
   annotation.
3. Abort unless these two sets have a non-null intersection.

Fixes #2555.

Run Details

2327 of 3501 relevant lines covered (66.47%)

0.66 hits per line

hypothesis / h / 8251 / 1
66%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8251.1

hypothesis / h / 8251 / 1 66% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8251.1

hypothesis / h / 8251 / 1
66%
master: 97%

README BADGES
x