1
82%
master: 82%

Ran 19 Sep 2015 05:13AM UTC

Files 51

Run time 1s

Badge

Embed ▾

Committed 19 Sep 2015 05:11AM UTC coverage: 81.634% (-4.4%) from 86.059%

Job # 54.1

Build Type

push

travis-ci

Committed by Commit bot

Commit Message

Refactor keys and queries in datastore service and implementation.
  * datastore.Query and datastore.FinalizedQuery are now first class objects
    in the service/datastore api.
  * datastore.Key is similarly a first class object. All luci/gae users will
    need to interact with `*ds.Key` now. This object gained all the superpowers
    that previously existed in the dskey subpackage of service/datastore.

The new Query objects are inspectable, and adjustable. Additionally, this
homogenizes they query generation between different implementations. The
normalization which normally occurs on the server-side is now done client-side.
This should ensure consistency between 'prod' and 'memory' implementations.

Additionally, the new FinalizedQuery object gains a GQL() method which should
(hopefully) allow trivial debugging by printing a query. You should be able to
copy and paste the generated GQL* into the appengine dashboard and see what
your request was querying for.

* With the exception of Cursors, which currently have no textual format in the
GQL schema.

R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org
BUG=533024

Review URL: https://codereview.chromium.org/1355783002

Run Details

4725 of 5788 relevant lines covered (81.63%)

588.89 hits per line

luci / gae / 54 / 1
82%
master: 82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 54.1

luci / gae / 54 / 1 82% master: 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 54.1

luci / gae / 54 / 1
82%
master: 82%

README BADGES
x