• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taskforcesh / bullmq / #445 / 1
88%
master: 88%

Build:
DEFAULT BRANCH: master
Ran 15 Jul 2021 02:28PM UTC
Files 69
Run time 24s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Jul 2021 02:26PM UTC coverage: 89.531% (-0.08%) from 89.615%
#445.1

push

manast
fix(queue): ensure the Queue constructor doesn't try to set queue options if the client is closed

In my app we disconnect queues sometimes quite quickly after constructing them, and see this error every so often in our CI logs:

```
/app/node_modules/bullmq/node_modules/ioredis/built/redis/index.js:620
        command.reject(new Error(utils_1.CONNECTION_CLOSED_ERROR_MSG));
                       ^
Error: Connection is closed.
    at Redis.sendCommand (/app/node_modules/bullmq/node_modules/ioredis/built/redis/index.js:620:24)
    at Redis.hset (/app/node_modules/bullmq/node_modules/ioredis/built/commander.js:111:25)
    at /app/node_modules/bullmq/src/classes/queue.ts:29:14
```

I am not exactly sure why it only happens sometimes but not others, but regardless, I think it's a good idea not to try to run the floating `hset` in the queue constructor if the client has been closed. This prevents that by first checking if the client has been closed before doing this floating work.

837 of 1080 branches covered (77.5%)

Branch coverage included in aggregate %.

5312 of 5788 relevant lines covered (91.78%)

144.2 hits per line

Source Files on job #445.1
  • Tree
  • List 0
  • Changed 24
  • Source Changed 1
  • Coverage Changed 24
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 445
  • b40c6eb9 on github
  • Prev Job for on master (##444.1)
  • Next Job for on master (##446.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc