1
100%
master: 100%

Ran 09 Jun 2021 05:35PM UTC

Files 32

Run time 17s

Badge

Embed ▾

Committed 09 Jun 2021 05:34PM UTC coverage: 100.0%. Remained the same

Job # 2.5.8

Build Type

push

travis-ci

Committed by

Sinjo

Commit Message

Fix URI escaping of spaces in push.rb

When `URI.escape` was deprecated, we switched to using `CGI.escape` to
construct the request path in push.rb.

The problem with that is that it mishandles spaces, encoding them as `+`
rather than `%20`. This leads to literal `+` characters in metric
labels, which is a bug.

This commit uses `ERB::Util.url_encode` instead, which gives us the
behaviour we want.

It's not the part of the standard library I expected to use for this,
but it's the only one that seems to have the behaviour we want and that
hasn't disappeared in Ruby 3.0. `WEBrick::HTTPUtils.escape` seems
similar on the surface, but doesn't encode `&`. Presumably it's intended
as a best-effort way to encode an entire URL, and has to assume that any
`&` character is a separator between query params.

Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>

Run Details

1650 of 1650 relevant lines covered (100.0%)

15.78 hits per line

prometheus / client_ruby / 741 / 1
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 741.1 (2.5.8)

prometheus / client_ruby / 741 / 1 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 741.1 (2.5.8)

prometheus / client_ruby / 741 / 1
100%
master: 100%

README BADGES
x