3
79%
master: 79%

Ran 28 Apr 2021 05:44PM UTC

Files 310

Run time 47s

Badge

Embed ▾

Committed 28 Apr 2021 05:35PM UTC coverage: 78.885% (-0.001%) from 78.886%

Job # 7009.3

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Fix node selector query split-response (#2242)

The DataStore query that returns the list of agent node selectors is currently sorted by row ID, which under certain circumstances can cause it to split the selectors for a given agent ID into more than one entry in the aggregated results. The only caller is the full entry cache, which does not handle this well, which can cause agents to not be associated with a node alias whose selectors end up spanning these splits.

This change fixes the query to order by SPIFFE ID instead of row ID so that the selectors for a given agent are grouped together and returned in a single entry in the aggregated results.

It also aggregates the results differently such that the order does not matter for correctness so that the code is resilient against a similar bug in the future.

Signed-off-by: Andrew Harding <aharding@vmware.com>

Run Details

23693 of 30035 relevant lines covered (78.88%)

17.96 hits per line

spiffe / spire / 7009 / 3
79%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7009.3

spiffe / spire / 7009 / 3 79% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7009.3

spiffe / spire / 7009 / 3
79%
master: 79%

README BADGES
x