wikimedia
/
parsoid
/
618
/
1
85%
master: 85%
master: 85%
|
Ran
|
Files
71
|
Run time
3s
|
Badge
Embed ▾
README BADGES
|
coverage: 85.436% (-0.007%) from 85.443%
push
travis-ci
C. Scott Ananian
Bracketed links must also have at least one character after the protocol. The regexp in Parser.php is: $this->mExtLinkBracketedRegex = '/\[(((?i)' . $this->mUrlProtocols . ')' . self::EXT_LINK_URL_CLASS . '+)\p{Zs}* This is after template expansion, of course, so we need to be a little more careful in our tokenizer. But we can still enforce the "at least one character after protocol" rule. Also tweak how this rule is enforced in the general URL tokenizer. We were inadvertently disallowing "http://192.168.0.1" as valid URL since we were incorrectly enforcing "one character of path" and ignoring the address portion. Now the address counts toward the post-protocol characters. Related to I5d728e6ac (although that dealt with autolinks). This exposes a few more IPv6 parsing bugs (T23261) on the blacklist, in sometimes surprising ways. Generally we truncate URLs at the open bracket so http://[abcd] used to be "valid" despite it parsing as a bare protocol ("http://"). Now these are generally invalid, causing blacklist additions. Change-Id: Id83841ff6
11832 of 13849 relevant lines covered (85.44%)
20933.21 hits per line
