spesmilo / electrum / 11494 / 1

63%

master: 63%

push

travis-ci

<a href="https://github.com/spesmilo/electrum/commit/<a class=hub.com/spesmilo/electrum/commit/6e1caf7e8838e0d3e81105f32ac13f863102f1bf">6e1caf7e8<a href="https://github.com/spesmilo/electrum/commit/6e1caf7e8838e0d3e81105f32ac13f863102f1bf">&quot;&gt;AppImage build: Include libxcb into the image

Ubuntu 20.04 needs `libxcb-xinerama.so.0`
and Debian 10 needs `libxcb-util.so.1` for the Qt `xcb` plugin.

-----

ported from https://github.com/Electron-Cash/Electron-Cash/commit/</a><a class="double-link" href="https://github.com/spesmilo/electrum/commit/<a class="double-link" href="https://github.com/spesmilo/electrum/commit/380f04a8054fe9fd9169721089c5da360f9d0807">380f04a80</a>">380f04a80</a><a href="https://github.com/spesmilo/electrum/commit/6e1caf7e8838e0d3e81105f32ac13f863102f1bf">

see https://github.com/Electron-Cash/Electron-Cash/issues/2196

-----

In particular, see this comment:

&gt;&gt; I confirmed that both Ubuntu 20.04 and Debian 10.8 clean install have an issue with the 4.2.4 AppImage.
&gt;
&gt; Any idea what broke it? I assume it used to work.

Yes, it did work in 4.2.3 which used PyQt5 5.13.2. I just had a look at the xcb plugin and it definitely has less dependencies:
```
ago@ubuntu2004vm:~/src/Electron-Cash/dist$ ldd squashfs-root/usr/lib/python3.6/site-packages/PyQt5/Qt/plugins/platforms/libqxcb.so|grep xcb
        libX11-xcb.so.1 =&gt; /lib/x86_64-linux-gnu/libX11-xcb.so.1 (0x00007f0ec9d07000)
        libxcb.so.1 =&gt; /lib/x86_64-linux-gnu/libxcb.so.1 (0x00007f0ec9cdd000)
        libxcb-xkb.so.1 =&gt; /lib/x86_64-linux-gnu/libxcb-xkb.so.1 (0x00007f0ec6ead000)
```

compared to PyQt5 5.15.2 in 4.2.4:
```
ago@ubuntu2004vm:~/src/Electron-Cash/dist$ ldd squashfs-root/usr/lib/python3.8/site-packages/PyQt5/Qt/plugins/platforms/libqxcb.so|grep xcb
        libX11-xcb.so.1 =&gt; /lib/x86_64-linux-gnu/libX11-xcb.so.1 (0x00007fcb5715f000)
        libxcb-icccm.so.4 =&gt; /lib/x86_64-linux-gnu/libxcb-icccm.so.4 (0x00007fcb57158000)
        libxcb-image.so.0 =&gt; /lib/x86_64-linux-gnu/libxcb-image.so.0 (0x00007fcb56f51000)
        libxcb-shm.so.0 =&gt; /lib/x86_64-linux-gnu/libxcb-shm.so.0 (0x00007fcb56f4c000)
        libxcb-util.so.1 => /lib/x86_64-linux-gnu/libxcb-util.so.1 (0x000... (continued)

15147 of 25971 relevant lines covered (58.32%)

0.58 hits per line